Skip to content

feat(charts/dex): Use tpl for dynamic image values and add digest #154

Merged
sagikazarmark merged 1 commit intodexidp:masterfrom
kozmagabor:make-image-more-configurable
Mar 21, 2025
Merged

feat(charts/dex): Use tpl for dynamic image values and add digest #154
sagikazarmark merged 1 commit intodexidp:masterfrom
kozmagabor:make-image-more-configurable

Conversation

@kozmagabor
Copy link
Copy Markdown
Contributor

Overview

What this PR does / why we need it

Special notes for your reviewer

  • Replaced static values with tpl for image repository, tag, and digest to allow the parent chart’s values to be passed dynamically to subchart.
  • Allow image pull using digest

Checklist

  • Change log updated in Chart.yaml (see the contributing guide for details)
  • Chart version bumped in Chart.yaml (see the contributing guide for details)
  • Documentation regenerated by running make docs

…port

Signed-off-by: Gabor Kozma <gabo@kozmagabor.com>
Copy link
Copy Markdown
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagikazarmark sagikazarmark merged commit 65db60c into dexidp:master Mar 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants